catalyst / moodle-MDL-70329

GNU General Public License v3.0
5 stars 4 forks source link

Question bank: Decouple adding a question from finding a question #354

Open mattporritt opened 3 years ago

mattporritt commented 3 years ago

Currently in the question bank the "finding" of a question is coupled to "adding" a question. With the new filtering we need to break that coupling.

Currently in Moodle question bank display, the first step is to select a category from a dropdown list. This then displays the questions in this category in the table below. There is a call to action via the "create new question" button. When this button is clicked the workflow to add a new question is started. The question will be added to the selected category.

Once filtering is implemented questions displayed will be based on the results of a set of filter conditions, where a category will just be one of the criteria. Will still want to have a button to add a question, but how do we manage which category that question goes to?

I've had a think about this and have come up with two options:

Option 1: Select Category from button press image

In this option when you click the "create new question button you are presented with a list of categories in the current question bank. This has the advantage of being the same workflow as the bulk action UI

Option 2: Incorporate category selection into the question selection modal image

In this option we have added the question bank categories to the modal to select the question type from, with a sensible default

Option 3: image

Just use the category selection that already exists in the question edit form:

timhunt commented 3 years ago

This seems to be a non-issue.

When you click the 'Add new question' button, you get to this form: https://qa.moodledemo.net/question/bank/editquestion/question.php?courseid=2&sesskey=DZ1qPeDoG0&qtype=match&returnurl=%2Fquestion%2Fedit.php%3Fcourseid%3D2&courseid=2&category=2 whic includes a drop-down to choose which category the question should go into.

That does, intelligently, pick as default the currently selected category - but if it is not obvious what that is, then we could just pick any one as default.

Or, we could make it a required field, and add a 'Choose...' blank option, so the user is forced to think about it (if we have not been able to pick a sensible default ourselves.)

The other issue is, when you finishe creating the question, you might be taken back to the question bank with the new question not visible.

We should add a notification saying "You question 'New question' was created" or something.

abonaccorso commented 3 years ago

I agree with Tim that the form he linked covers the issue.

And I would vote for a sensible default, if we can find any that works for all cases and never throws an error.

I like the idea of the notification saying "You question 'New question' was created". But why should the newly created question not be visible when you come back to the question bank? Can we try to have the question visible?

timhunt commented 3 years ago

It man not be a problme now, but when we have sophisticated filtering, you might create a new question which does not match the current filter rules, and so does not show up. Like with trying to find a sensible default for the category option, if we are clever we might be able to set sensible defaults for other thngs like tags.

mattporritt commented 3 years ago

Ok , agreed. We'll use a sensible default on the question edit form and then after the question is created and we return to the question bank page we'll show a notification that a question was created.

Cheers