search

catalyst / moodle-MDL-70329

GNU General Public License v3.0
5 stars 4 forks source link

mdl 72321 `db error` fix 375 #390

Closed marcghaly closed 2 years ago

marcghaly commented 2 years ago

Hi @safatshahin, this is the PR for this issue : https://github.com/catalyst/moodle-MDL-70329/issues/375 Thank you

safatshahin commented 2 years ago

Hi @marcghaly Thank you for your work on this. Unfortunately, there is still some work that needs to be done.

  1. String: Please specify a category to retrieve questions -> it's not the category always required, so please change it to: Please specify a condition to retrieve questions.
  2. I can see if you don't have the condition, it still renders questions and doesn't shows the notification. To reproduce: add a condition, lets say a category, just remove the category not the whole condition and click Apply. This needs to be fixed where it can render the data but it should show notification please specify a condition.
safatshahin commented 2 years ago

I have integrated this fix by making changes to the string. will create another issue for addressing the other issue. thank you for your contribution to this. Cheers