search

catalyst / moodle-MDL-70329

GNU General Public License v3.0
5 stars 4 forks source link

mdl 72321 api changes 382 tag hidden #421

Closed marcghaly closed 2 years ago

marcghaly commented 2 years ago

Hi @safatshahin, I moved the tag and hidden condition, I could test the hidden one as it is being used, but it seem that the tag one is not being called anywhere. This PR is a continuity for issue #382. Thank you !

safatshahin commented 2 years ago

Hi @marcghaly Thank you for your work on this. The patch looks alright, just some changes:

  1. The mustache is deleted and moved to the plugin, document them in upgrade.txt. If there are other movements that happened before, not documented, feel free to do that in this PR.
  2. In renderer, the method should not be deleted, instead, deprecate them and mark for final deprecation. Cheers!
marcghaly commented 2 years ago

Hi @safatshahin,

  1. I added doc in upgrade.txt
  2. I readded deleted method with deprecation. Thank you !
safatshahin commented 2 years ago

Hi @marcghaly Thanks for the changes, this has been integrated into the filtering base. Cheers!