catalyst / moodle-auth_basic

Moodle Basic Authentication, easily test using curl, webpage test, page speed etc
https://moodle.org/plugins/auth_basic
7 stars 6 forks source link

3.10 - PHPUnit fails #24

Closed aspark21 closed 3 years ago

aspark21 commented 4 years ago

PHPUnit test environment setup complete.

PHP Fatal error: Declaration of auth_basic_test::setUp() must be compatible with PHPUnit\Framework\TestCase::setUp(): void in /var/www/html/auth/basic/tests/auth_basic_test.php on line 40' stderr_lines: stdout: |- Moodle 3.10 (Build: 20201109), f76515bf7b7ee0ccc3d90263ac847da8d45d8d60 Php: 7.3.20, mysqli: 5.7.31, OS: Linux 3.10.0-1160.2.1.el7.x86_64 x86_64

Fatal error: Declaration of auth_basic_test::setUp() must be compatible with PHPUnit\Framework\TestCase::setUp(): void in /var/www/html/auth/basic/tests/auth_basic_test.php on line 40
aspark21 commented 4 years ago

Will be due to https://docs.moodle.org/dev/Writing_PHPUnit_tests#Upgrading_unit_tests_to_work_with_Moodle_3.10_and_up_.28PHPUnit_8.5.29

aspark21 commented 3 years ago

Still an issue for 3.11

mattporritt commented 3 years ago

PR merged in.