auth_outage: Update function calls to conform to PHPUnit 9 deprecations [Totara 13]

catalyst / moodle-auth_outage

Planned, graduated user and admin friendly moodle outages

https://moodle.org/plugins/auth_outage

17 stars 33 forks source link

auth_outage: Update function calls to conform to PHPUnit 9 deprecations [Totara 13] #219

Closed gusauwerda closed 3 years ago

gusauwerda commented 3 years ago

assertContains() is deprecated, and replaced by assertStringContainsString() in PHPUnit 9, and Totara 13 issues warnings in relation to this

danmarsden commented 3 years ago

seems we also need to change assertNotContains -> assertStringNotContainsString

yao9394 commented 3 years ago

The travis check fails because moodle 36 has lower version of phpunit, we may want to reserve a branch for lower version of moodle, such as moodle 36?

cheers

ScottVerbeek commented 3 years ago

Opened a new branch and created a new pull request combining this and https://github.com/catalyst/moodle-auth_outage/pull/219