catalyst / moodle-auth_outage

Planned, graduated user and admin friendly moodle outages
https://moodle.org/plugins/auth_outage
17 stars 33 forks source link

Outage banner overlaps page content #222

Closed golenkovm closed 3 years ago

golenkovm commented 3 years ago

Here is a few screenshots how does it look like:

1) Grading page: image

2) Main dashboard (Customize this page is covered): image

3) Forum grading page: image

And many others (Site admin, course, activities and so on).

Seems to be a regression of #211

brendanheywood commented 3 years ago

Every theme is different, we will at best be able to get this working with boost but each theme needs custom config to make it work

mattporritt commented 3 years ago

I'm looking at #223 PR for this. Agreed this will fix the issue for Boost, and for that reason I'm happy to merge it in. As this needs to be done anyway However, @brendanheywood pointed out. This will not fix it for all themes. A more universal fix would be to add a config setting to add a "theme offset" that should default to work for boost, but allow admins to adjust for their sites theme

golenkovm commented 3 years ago

Thank you @mattporritt I've just created a new issue for the universal fix. Closing this off.