search

catalyst / moodle-auth_outage

Planned, graduated user and admin friendly moodle outages
https://moodle.org/plugins/auth_outage
17 stars 33 forks source link

Fix banner overlap #223

Closed golenkovm closed 3 years ago

golenkovm commented 3 years ago

This is a fix for #222

golenkovm commented 3 years ago

Assignment grading page: image

Forum grading page: image

Main dashboard: image

Site admin: image

Course page: image

golenkovm commented 3 years ago

The only thing I couldn't figure out is why top: 100px; won't work for body.auth_outage #page and where that top margin (about 20px) comes from. I was able to fix the issue by setting margin-top to 130px, where 130 = 150 - that mysterious 20px gap on top of #page element.

image

golenkovm commented 3 years ago

Hi all,

I figure out where the mystery 22px came from and fixed it. There was an empty div inside the warning box: <div class="auth_outage_warningbar_spacer">&nbsp;</div>. Not sure why it was added, but now the banner looks good. I also found overlapped modal dialogs and fixed them:

Add an activity dialog: image

Enrol users dialog: image

PS: The banner was removed from the assignment grading page as part of this commit: https://github.com/catalyst/moodle-auth_outage/commit/a6bb7f4bc28e8e917e9f954861828ed7814dd5d2 however the rest of the screenshots provided above are still up to date.

This is ready for review.

Cheers, Mikhail