search

catalyst / moodle-auth_outage

Planned, graduated user and admin friendly moodle outages
https://moodle.org/plugins/auth_outage
17 stars 33 forks source link

The checkfinished endpoint should be execpt from the 503 maintenance logic #233

Closed brendanheywood closed 3 years ago

brendanheywood commented 3 years ago

ie if you are NOT in the ip list, and you hit this check ajax, you should always get the real script and not be intercepted by the outage page itself and get a 503.

brendanheywood commented 3 years ago

Needs something like 

define('NO_OUTAGE', true);

and for the boostrap to detect this

yao9394 commented 3 years ago

https://github.com/catalyst/moodle-auth_outage/pull/238 PR attached

yao9394 commented 3 years ago

Hi @brendanheywood Thanks for your help on explaining this issue. It seems the checkfinished ajax call happens when there is warning bar, but maintenance mode blocks that bar as well. I believe there might be somewhere else need to make this call, which I still don't know. Could you please have a look at this PR when you get a chance, and let me know if there is any more change needed to address this issue? Thanks,

John Y