catalyst / moodle-auth_outage

Planned, graduated user and admin friendly moodle outages
https://moodle.org/plugins/auth_outage
17 stars 32 forks source link

PHP Notices when a site is running in a subdir #245

Closed golenkovm closed 3 years ago

golenkovm commented 3 years ago

When a site is running in a subdir the site log is full of PHP Notices:

moodle_1   | 2021/03/18 04:51:30 [error] 20#20: *780 FastCGI sent in stderr: "PHP message: PHP Notice:  Undefined index: url in /siteroot/subdir/auth/outage/bootstrap.php on line 76PHP message: PHP Stack trace:PHP message: PHP   1. {main}() /siteroot/subdir/lib/requirejs.php:0PHP message: PHP   2. require() /siteroot/subdir/lib/requirejs.php:31PHP message: PHP   3. require() /siteroot/subdir/config.php:56" while reading response header from upstream, client: 192.168.224.1, server: http://localhost, request: "GET /subdir/lib/requirejs.php/-1/theme_boost/aria.js HTTP/1.1", upstream: "fastcgi://unix:/var/run/php/php7.4-fpm.sock:", host: "localhost", referrer: "http://localhost/subdir/my/"
golenkovm commented 3 years ago

This seems to be a typo, as url is not a documented key: https://www.php.net/manual/en/function.parse-url.php

golenkovm commented 3 years ago

Closing this as fixed