catalyst / moodle-auth_outage

Planned, graduated user and admin friendly moodle outages
https://moodle.org/plugins/auth_outage
17 stars 32 forks source link

Timeout regression with inline background image style inclusion. #261

Closed Peterburnett closed 3 years ago

Peterburnett commented 3 years ago

Some of our sites are seeing gateway timeouts when attempting to load/create outage pages:

image

It seems there are a bunch of calls to include files that result from the change to load background images in inline css.

I think the selector is too broad, leading to a ton of overhead on repeated curl calls.

https://github.com/catalyst/moodle-auth_outage/blob/MOODLE_39_STABLE/classes/local/controllers/maintenance_static_page_generator.php#L53

This should probably also use get_all_urls_from_stylesheet if possible