catalyst / moodle-auth_outage

Planned, graduated user and admin friendly moodle outages
https://moodle.org/plugins/auth_outage
17 stars 34 forks source link

Add reusable workflows #274

Closed Anupamatd closed 2 years ago

danmarsden commented 2 years ago

looks like a nice start! - good to see this is possible!

Personally I'd prefer to see this simplified a bit more...

In our plugin (eg auth_outage) workflow I'd like to see a config var that defines a list of versions this plugin supports eg something that just holds some branch names: MOODLE_39_STABLE, MOODLE_310_STABLE, master

and then a one line include of a shared workflow file - the one line shared workflow itself would then figure out which versions of php, which versions of the database and any other dependences we want to normally run..

There's quite a lot of duplication in the custom workflows you've written (one for each branch) - I think we could probably make that easier to maintain by re-using a lot more in a single file?

Anupamatd commented 2 years ago

Thank you @danmarsden for the comments !!! Sure, I'll fix this. Thanks, Anu

Anupamatd commented 2 years ago

Hi @danmarsden ,

Implemented below items based on the comment.

Could you please review?

Thanks, Anu