catalyst / moodle-auth_outage

Planned, graduated user and admin friendly moodle outages
https://moodle.org/plugins/auth_outage
17 stars 32 forks source link

Changed event type to a site wide one #283

Closed bozicm closed 2 years ago

bozicm commented 2 years ago

Moodle does not recognize eventtype = 'auth_outage' and therefore does not respond well in the calendar view to this event type (defaults dropdown to user event, icon and coloring is off). Since outage is site wide event I figured 'site' event type would be appropriate.

danmarsden commented 2 years ago

There are several references to eventtype == 'auth_outage' in our tests and other areas of the auth_outage code so this would break a bunch of different stuff. Can you provide a bit more info on what you're trying to fix here? - maybe some screenshots?

brendanheywood commented 2 years ago

I'm not sure of the problem either, but maybe the correct solution here is implementing more of the callbacks like _calendar_is_event_visible and _calendar_provide_event_action etc. The eventtype should be specific to the component

bozicm commented 2 years ago

Ok, I think I misinterpreted the validity of event type too quickly. I was looking at the event in the calendar view and saw that dropdown for 'Type of Event' can't map to 'auth_outage' so I thought it should be mapped to 'site':

image

I guess you can close down this PR.

brendanheywood commented 2 years ago

thanks anyway @bozicm