search

catalyst / moodle-auth_outage

Planned, graduated user and admin friendly moodle outages
https://moodle.org/plugins/auth_outage
17 stars 32 forks source link

ISSUE304 - css change for warning box header and title #305

Closed meepster-nz closed 1 year ago

meepster-nz commented 1 year ago

WR #393165

Added new css to align the warning box heading and title to the center rather than using negative offset margins. Added a mobile breakpoint also for the heading to reduce font size.

golenkovm commented 1 year ago

Hi @meepster-nz

Thanks for raising this. May I ask you to provide some screnshots that show the change (before and after)? Please make sure that core theme is used, not a client one.

Cheers, Misha

meepster-nz commented 1 year ago

Hi @golenkovm see below:

BEFORE

Outage-before Outage-mobile-before

AFTER

Outage-after Outage-mobile-after

golenkovm commented 1 year ago

Cool, thanks for the screenshots. Yeah, this issue looks familiar to me. Is there a chance we could make CI checks green?

meepster-nz commented 1 year ago

hey @golenkovm i dont even know what the issues are with those CI checks

dmitriim commented 1 year ago

@meepster-nz wondering if this will break any of the existing installations where some fixes could be already done in a theme...

P.S. it doesn't look like CI is complaining on anything that should be part of this PR. Looks like some new checks that should be fixed in another PR.

meepster-nz commented 1 year ago

@dmitriim possibly, depending on how it was implemented. I will check now with the latest site we just did a fix for.

meepster-nz commented 1 year ago

@dmitriim have just added some fallback css to hopefully prevent some existing hack css in themes. This fixes the CPA theme,

meepster-nz commented 1 year ago

Updated the README with some additional scss and css for Moodle and Totara