search

catalyst / moodle-auth_outage

Planned, graduated user and admin friendly moodle outages
https://moodle.org/plugins/auth_outage
17 stars 34 forks source link

Function strftime deprecated in php 8.1 #319

Closed SashaAnastasi closed 1 year ago

SashaAnastasi commented 1 year ago

Moodle 4.2 has a core function to replace it: \core_date::strftime I've created a branch with this fix here This branch needs a Moodle 4.2 target branch.

Tōtara 17 has a core function to replace it: \totara_core\strftime::format I've created a branch with this fix here This branch needs a Tōtara 17 target branch.

danmarsden commented 1 year ago

I was initially leaning towards writing a if class exists style function in there to support all the versions/forks... but... do we actually need to print a timestamp there at all? - I'm inclined to just delete that call completely!

danmarsden commented 1 year ago

scrap that... Brendan rightly points out we could just do something like userdate(time()) in there instead.

danmarsden commented 1 year ago

fixed in #320