search

catalyst / moodle-auth_outage

Planned, graduated user and admin friendly moodle outages
https://moodle.org/plugins/auth_outage
17 stars 32 forks source link

Behat test runs dies #323

Open cybernotic opened 11 months ago

cybernotic commented 11 months ago

Hi, After this commit was made https://github.com/catalyst/moodle-auth_outage/commit/4aa5976ea83247373ba73839f8e0e93c42d25195 our moodle-docker behat tests finishes in 0 seconds with no results. I forked this repo and made a change in tests/behat/behat_auth_outage.php line 33: #defined('MOODLE_INTERNAL') || die(); This resolved our issue. Please can you look in to this or is there somthing we would need to do at our end because MOODLE_INTERNAL is not defined?

aspark21 commented 11 months ago

@cybernotic can you submit a merge request for this fix.

aspark21 commented 11 months ago

Seems this slipped through the net because behat running is disabled in this plugin's ci config https://github.com/catalyst/moodle-auth_outage/blob/MOODLE_39_STABLE/.github/workflows/ci.yml#L10

cybernotic commented 11 months ago

@cybernotic can you submit a merge request for this fix.

merge request sent