catalyst / moodle-auth_saml2

SAML done 100% in Moodle, fast, simple, secure
https://moodle.org/plugins/auth_saml2
70 stars 132 forks source link

Fix tester.php and improve the UI of test.php #680

Open brendanheywood opened 2 years ago

brendanheywood commented 2 years ago

What happened?

Using the tester link from the auth manage page often fails

Exception - Call to a member function set_context() on null

Debug info: Error code: generalexceptionmessage Stack trace: line 36 of /auth/saml2/tester.php: Error thrown line 1046 of /auth/saml2/classes/auth.php: call to include() line 75 of /auth/test_settings.php: call to auth_saml2\auth->test_settings()

What you expected:

On top of this, we can still safely call some moodle libs and format the test page much nicer, in particular format it into a table and make it easier to cut and paste the keys out of the attributes into the admin settings