search

catalyst / moodle-auth_saml2

SAML done 100% in Moodle, fast, simple, secure
https://moodle.org/plugins/auth_saml2
71 stars 133 forks source link

Fix the settings page exception caused by trying to call a function on a NULL. #686

Closed cwarwicker closed 2 years ago

cwarwicker commented 2 years ago

Fixes: #656

danmarsden commented 2 years ago

looks like a similar change also proposed in #662 but we weren't aware that would also fix #656

cwarwicker commented 2 years ago

Just following up, as the client has chased. Do you think this, or the other similiar fix, are likely to be reviewed/approved soonish?

Thanks.

danmarsden commented 2 years ago

just dropped in a rebase of Alex's patch - if tests pass, I'll merge it in, (closing this one.)