catalyst / moodle-auth_saml2

SAML done 100% in Moodle, fast, simple, secure
https://moodle.org/plugins/auth_saml2
70 stars 132 forks source link

Moodle expects username to always be lower case. #724

Closed danmarsden closed 1 year ago

danmarsden commented 1 year ago

update_user_record_from_attribute_map will automatically set username tolower case, however when the username mapping field is empty we fail over to using uid and that doesn't always get set to lower case.

skodak commented 1 year ago

Hi guys, isn't this going to cause problems for non-ascii languages? I think this should be using utf8 aware case lowering, right?