search

catalyst / moodle-auth_saml2

SAML done 100% in Moodle, fast, simple, secure
https://moodle.org/plugins/auth_saml2
70 stars 132 forks source link

fix strtolower calls incompatible with utf-8 #725

Open skodak opened 1 year ago

skodak commented 1 year ago

Please note I did not test this patch and I am not sure the upstream library actually supports utf-8 usernames.

danmarsden commented 1 year ago

Thanks Petr - good spotting, this is pretty historic (we've always just used php's strtolower for this) but we should probably add some utf-8 tests to the user_extractor_test class to cover this as well.