search

catalyst / moodle-auth_saml2

SAML done 100% in Moodle, fast, simple, secure
https://moodle.org/plugins/auth_saml2
70 stars 132 forks source link

set SESSION->saml2idp during unsolicited logins #759

Closed skodak closed 2 weeks ago

skodak commented 1 year ago

This makes the IdP known in saml_login_complete() and tenant callback.

skodak commented 1 year ago

I suppose this might affect Moodle for Workplace too because the callback for tenant support with $SESSION->saml2idp originated there

brendanheywood commented 1 year ago

thanks @skodak - @kabalin are you able to review this in the context of workplace?

kabalin commented 1 year ago

thanks @skodak - @kabalin are you able to review this in the context of workplace?

This change does not affect Workplace (tested it thoroughly). Cleared to land :)

skodak commented 3 weeks ago

any news?

danmarsden commented 3 weeks ago

looks like we forgot about this one - happy to merge, but someone needs to update the patch for the new version of simplesamlphp - I think the change needs to go here now instead: https://github.com/catalyst/moodle-auth_saml2/blob/MOODLE_39_STABLE/.extlib/simplesamlphp/modules/saml/src/Auth/Source/SP.php#L1136

skodak commented 3 weeks ago

patch updated