catalyst / moodle-auth_saml2

SAML done 100% in Moodle, fast, simple, secure
https://moodle.org/plugins/auth_saml2
70 stars 132 forks source link

Use iso country code in xml:lang attribute for metadata #772

Closed catalystfd closed 9 months ago

catalystfd commented 9 months ago

If you're using a custom Moodle translation pack, especially one of the odd ones like the pirate translation pack, some IDP's appear to refuse to parse the metadata file because en_arr or similar are not valid xml:lang attributes.

This uses the iso6391 code defined for each language instead, which hopefully will have wider support.

catalystfd commented 9 months ago

is the totara branch maintained?

danmarsden commented 9 months ago

yes it is - we have to maintain a fork due to the JS stuff... :-(