Open jwalits opened 8 months ago
It looked like previously the AllowCreate flag (https://github.com/catalyst/moodle-auth_saml2/blob/MOODLE_39_STABLE/settings.php#L201-L206) wasn't really supported in the SAML request.
With the latest change, it looks like we are explicitly setting it to true in the SAML config: https://github.com/catalyst/moodle-auth_saml2/blob/MOODLE_39_STABLE/config/authsources.php#L66
Need to find a middle ground for that value. Having it hardcoded to true in the config doesn't feel right.
It looked like previously the AllowCreate flag (https://github.com/catalyst/moodle-auth_saml2/blob/MOODLE_39_STABLE/settings.php#L201-L206) wasn't really supported in the SAML request.
With the latest change, it looks like we are explicitly setting it to true in the SAML config: https://github.com/catalyst/moodle-auth_saml2/blob/MOODLE_39_STABLE/config/authsources.php#L66
Need to find a middle ground for that value. Having it hardcoded to true in the config doesn't feel right.