search

catalyst / moodle-auth_saml2

SAML done 100% in Moodle, fast, simple, secure
https://moodle.org/plugins/auth_saml2
70 stars 132 forks source link

"Deprecated: Creation of dynamic property" warnings with PHP 8.2 #781

Closed LMachucaORT closed 4 months ago

LMachucaORT commented 8 months ago

PHP Deprecated: Creation of dynamic property auth_saml2\admin\setting_button::$label is deprecated in auth/saml2/classes/admin/setting_button.php on line 52 PHP Deprecated: Creation of dynamic property auth_saml2\admin\setting_button::$href is deprecated in auth/saml2/classes/admin/setting_button.php on line 53

PHP Deprecated: Creation of dynamic property auth_plugin_saml2::$spname is deprecated in auth/saml2/classes/auth.php on line 111 PHP Deprecated: Creation of dynamic property auth_plugin_saml2::$certpem is deprecated in auth/saml2/classes/auth.php on line 112 PHP Deprecated: Creation of dynamic property auth_plugin_saml2::$certcrt is deprecated in auth/saml2/classes/auth.php on line 113 PHP Deprecated: Creation of dynamic property auth_plugin_saml2::$metadatalist is deprecated in auth/saml2/classes/auth.php on line 119

sammarshallou commented 7 months ago

We see this too, I'll submit a fix shortly.

gemguardian commented 4 months ago

@sammarshallou - I wonder if there is a timeline on when to saml2 php 8.2 version will be available?

sammarshallou commented 4 months ago

@gemguardian No use asking me, that's down to Catalyst. We are using it here in PHP 8.2; according to our customisation notes we only have the published plugin, plus PR #789 which is the one linked here, (And one other local change which is because our login IdP has a bug, not related to PHP 8.2.)

gemguardian commented 4 months ago

@sammarshallou thank you for the information, sorry I mixed up names thought you worked for Catalyst. @danmarsden then I am tagging you - do you have any idea if Catalyst will commit the pull request ?

danmarsden commented 4 months ago

just merged it in.. there's a bit of a backlog on pull requests in here at the moment - hard to find someone internally with the time to test and review stuff on non-chargeable time these days... and my work day should have been long over by now too!! :-)

Thanks for the pr Sam (and for the reminder @gemguardian) :-)

gemguardian commented 4 months ago

@danmarsden thank you. Fully understand :)