search

catalyst / moodle-auth_userkey

Log in to Moodle using one time user key based login URL. Auth plugin for organising simple SSO (single sign on) between moodle and your external web application.
https://moodle.org/plugins/auth_userkey
83 stars 53 forks source link

settings.php for 3.2 to 3.4 Moodle version #21

Closed hoz1982 closed 6 years ago

dmitriim commented 6 years ago

Hey @hoz1982 ! Thanks for your contribution. Looks like travis is not happy. Could you please have a look and fix it before we can do review of your changes. Looks like it complains about some missing lang string.

hoz1982 commented 6 years ago

Hi @dmitriim! ok maybe it was something on the $option array... I'm opening a new pull request with the correct file.

dmitriim commented 6 years ago

Hi @hoz1982 ! Looks like you need to fix coding style in your code to make travis happy. Please see https://docs.moodle.org/dev/Coding_style for more info.

dmitriim commented 6 years ago

Also some unit tests are broken as well.

andrewhancox commented 6 years ago

I hadn't realised some else had already done this. I've got a working branch at https://github.com/andrewhancox/moodle-auth_userkey/tree/master_33

dmitriim commented 6 years ago

Hi @hoz1982

This functionality has just landed to MOODLE_33PLUS branch. Thank you for your work on this plugin.

Cheers, Dmitrii