Creation of dynamic property block_multiblock::$blocks is deprecated

catalyst / moodle-block_multiblock

Moodle plugin which allows you to embed multiple blocks within a single block region using different formats including tabs and accordions

GNU General Public License v3.0

12 stars 12 forks source link

Creation of dynamic property block_multiblock::$blocks is deprecated #109

Closed ewallah closed 5 months ago

ewallah commented 5 months ago

Using $this->blocks without declaring a @var array $blocks in the class generates a deprecated error in php8.2.

Exception - Unknown error type: Creation of dynamic property block_multiblock::$blocks is deprecated in [dirroot]/blocks/multiblock/block_multiblock.php on line 93

Debug info:
Error code: generalexceptionmessage

Stack trace:

line 157 of /lib/behat/lib.php: Exception thrown
line 93 of /blocks/multiblock/block_multiblock.php: call to behat_error_handler()
line 152 of /blocks/multiblock/block_multiblock.php: call to block_multiblock->load_multiblocks()
line 337 of /blocks/moodleblock.class.php: call to block_multiblock->get_content()
line 231 of /blocks/moodleblock.class.php: call to block_base->formatted_contents()
line 215 of /blocks/multiblock/block_multiblock.php: call to block_base->get_content_for_output()
line 1231 of /lib/blocklib.php: call to block_multiblock->get_content_for_output()
line 1289 of /lib/blocklib.php: call to block_manager->create_block_contents()
line 377 of /lib/blocklib.php: call to block_manager->ensure_content_created()
line 4130 of /lib/outputrenderers.php: call to block_manager->region_has_content()
line 28 of /theme/classic/layout/columns.php: call to core_renderer->blocks()
line 1477 of /lib/outputrenderers.php: call to include()
line 1403 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()
line 290 of /course/view.php: call to core_renderer->header()

Adding this to the code, fixes the error:

    /** @var array $blocks. */
    private $blocks;

danmarsden commented 5 months ago

Thanks @ewallah - feel free to submit a PR otherwise we'll try to come back to it soon.

danmarsden commented 5 months ago

thanks for the PR! :-)