search

catalyst / moodle-block_multiblock

Moodle plugin which allows you to embed multiple blocks within a single block region using different formats including tabs and accordions
GNU General Public License v3.0
12 stars 12 forks source link

Default settings for the multi block #80

Closed james-pearce-bath-ac closed 2 years ago

james-pearce-bath-ac commented 2 years ago

This is to add some default settings to the multi block, including a block title, default presentation style and default set of blocks to add to the multi block on creation.

james-pearce-bath-ac commented 2 years ago

I've made some changes to the PR to fix the requests. Please review and let me know if there is anything else that needs to be done.

james-pearce-bath-ac commented 2 years ago

I've made additional updates to the PR to bring back the block title but make it default to empty and sort the tests.

marxjohnson commented 2 years ago

Hi James, To avoid holding this up further, I fixed a couple of remaining issues and merged the branch. I squashed Muhammads, yours and my changes into a single commit each to preseve authorship but keep the commit history tidy. You can see that changes I made in my commit message: https://github.com/catalyst/moodle-block_multiblock/pull/80/commits/f663501580805da23c0b2ad0805c5a7ef084d9eb

marxjohnson commented 2 years ago

Thanks very much for your contribution!