search

catalyst / moodle-block_multiblock

Moodle plugin which allows you to embed multiple blocks within a single block region using different formats including tabs and accordions
GNU General Public License v3.0
12 stars 12 forks source link

Aria roles for the accordion style of multiblock - accessibility issue #81

Closed james-pearce-bath-ac closed 1 year ago

james-pearce-bath-ac commented 2 years ago

The multiblock accordion tabs have the role=”radio”. This could be confusing to a screenreader user. A better aria role might be "tab".

michaelkotlyar commented 1 year ago

Totally agree with removing the radio role there. Looking at the examples below, it might not be necessary to have a role at all since the element is already a button.

https://getbootstrap.com/docs/4.6/components/collapse/#accordion-example https://www.w3.org/WAI/ARIA/apg/example-index/accordion/accordion.html

michaelkotlyar commented 1 year ago

Finally got around to creating a PR for this

danmarsden commented 1 year ago

fixed in #90

danmarsden commented 1 year ago

reverted that and set it to use role="tab" as the mustache validation failed when we removed the role completely. - thanks!