search

catalyst / moodle-block_multiblock

Moodle plugin which allows you to embed multiple blocks within a single block region using different formats including tabs and accordions
GNU General Public License v3.0
12 stars 12 forks source link

Moodle 4 compatibility #84

Closed sharpchi closed 1 year ago

sharpchi commented 1 year ago

I've just run the behat tests on Moodle 4.0.3 and get the following errors: --- Failed scenarios: /var/www/html/blocks/multiblock/tests/behat/accordion.feature:7 /var/www/html/blocks/multiblock/tests/behat/basic_test.feature:7 /var/www/html/blocks/multiblock/tests/behat/defaultsettings.feature:27 /var/www/html/blocks/multiblock/tests/behat/dropdown.feature:7 /var/www/html/blocks/multiblock/tests/behat/merging_blocks.feature:7 /var/www/html/blocks/multiblock/tests/behat/tabbed.feature:7 /var/www/html/blocks/multiblock/tests/behat/tabbed_vertical_left.feature:7 /var/www/html/blocks/multiblock/tests/behat/tabbed_vertical_right.feature:7

The errors either relate to the "Customise this page" button not existing, or with regards to adding the block from the flat navigation

danmarsden commented 1 year ago

Thanks Mark - pull requests always welcome :-)

michaelkotlyar commented 1 year ago

I've made a PR here. There were also failures with the HTML block now being renamed as the Text block.