Closed marxjohnson closed 1 year ago
Approved by Anton S (haven't got write access to do it properly)
@catalyst-eu - I've just sent an invite to that account to be added to the EU group in the catalyst org repo (I assume that is a generic account rather than one "owned" by Anton? - (hopefully?) - I can't see a separate "real" account for Anton in github but ping me internally and I can add that too...
also - the github action pipelines on this repo were green before this patch, so we really need to fix the errors that it's now reporting before we merge in new changes... even though they don't look related, they look to be mostly an easy fix.
Hi Dan, It looks like they're mostly codechecker violations for MOODLE_INTERNAL checks that are no longer required, on files that I'm not otherwise touching. Good to get them fixed though, so remove them in a separate commit.
@danmarsden I have resolved those codechecker issues. The remaining CI failures are due to deprecated behat steps in Moodle 4.0+. I can't fix that as part of this PR as we will need to create new stable branch for <=3.11. I have created #96 to address it once this PR is merged.
Doh, ignore that. I must have based my branch on an older version of master. I rebased because it was conflicting and now I'm getting green across the board. I'll merge this in now.
that makes more sense! - I was getting confused by the errors it was reporting myself too!! - :-)
Fixes #94.