search

catalyst / moodle-cachestore_redissentinel

adds support for redis sentinel
2 stars 2 forks source link

No such file or directory: #1

Closed moxxuk closed 3 years ago

moxxuk commented 5 years ago

I can't get this working, mainly due to a required file not being present in lib.php:

require_once($CFG->libdir.'/redis/sentinel.php');

Where does this sentinel.php file come from?

Many thanks

danmarsden commented 5 years ago

I'm not completely sure why that was dropped in lib/redis - but heres the relevant file:

sentinel.zip

Feel free to submit a pull request to move that into the plugin's own directory instead of in /lib/

mrkskwsnck commented 3 years ago

@danmarsden Is this zipped sentinel.php file part of this project or of an external origin?

danmarsden commented 3 years ago

@mrkskwsnck - it's code that Catalyst staff have written to support this plugin - it should have Moodle's standard GPL statement at the top along with the copyright assigned to Catalyst IT - it's a class required for this plugin to work.

mrkskwsnck commented 3 years ago

@danmarsden Unfortunately, the zipped file has neither a license statement nor any other comments. Also, I could not find this file in any other of the Catalyst projects :-( Because of that I would not recommend to commit it to this project by a PR. IMHO

danmarsden commented 3 years ago

Thanks - I can confirm that the file was written by catalyst staff(Matt clarkson) and although it is missing that detail in the zip it is appropriate to add them. it sits in our private local repository but was added here as a zip in case someone else wants to use this code.

at some point we may get round to tidying this up ourselves but a PR would speed it up.

mrkskwsnck commented 3 years ago

Now, that I have my Redis/Sentinel Cluster up and running using this cache store, I created the PR https://github.com/catalyst/moodle-cachestore_redissentinel/pull/3 containing the missing class. Also I explained some essential configuration details in the README file, which were not obvious for me.

PS: I would appreciate it, if you would choose a license for this project. Preferably GPL v3 to be in sync with Moodle.

danmarsden commented 3 years ago

Thanks for the PR and the improved readme - great to hear it's working for you too!