Parametrised stack name, --stack-name and --remove-stack CLI options

[srdjan-catalyst]

Mini apocalypse:

• stack.template:
  • dynamic STACK and __BUCKET_PREFIX__ substitutions
  • S3User UserName and PolicyName, Lambda RoleName and FunctionName are STACK dependant
• class provision:
  • constructor: removed $bucketprefix, added $stack
  • There are only two main entry points: provision_stack() and remove_stack() that will do everything required for stacks and resource bucket
  • provision_stack(): -- params: $template and $replace, $replace must be set to true in order to replace an existing stack -- We are not specifying 'Parameters' on stack creation, let the template Default values do the job
• provision_test.php: mock_provision class instead of ReflectionMethod
• cli/provision.php:
  • new option --replace-stack - tied to provision_stack()
  • new option --remove-stack - tied to remove_stack()
  • new option --stack-name - tied to provision constructor
  • removed option --bucket-prefix - see "bucket names" above

[mattporritt]

This all looks broadly ok. It is a large refactoring, but as it's all provisioning related, even if something isn't quite right it won't break existing deployments. It's probably worth going over the existing code comments to see if they are still correct/needed. I found one that needs to be changed, but there may be more.

Cheers, Matt P