search

catalyst / moodle-fileconverter_librelambda

A Libre Office document converter for Moodle leveraging AWS Lambda
https://moodle.org/plugins/fileconverter_librelambda
Other
23 stars 18 forks source link

Implement support for further common file types #6

Open aspark21 opened 5 years ago

aspark21 commented 5 years ago

Would be great if jpg, txt and png could be supported by this plugin. We are now using the onedrive fileconverter as our primary but it doesn't support everything.

I've listed below the filetypes not supported by librelambda which unoconv supports and number of files in our system as a representation of proportions

jpg | 4098 txt | 775 png | 616 gif | 13 tiff | 7 xml | 3 bmp | 2 emf | 2 eps | 2 svg | 1 wps | 1

These are filetypes Onedrive supports which librelambda doesn't csv | 96 odp | 17 pptm | 12 ppsx | 6 potx | 4

Also can take a look at https://bitbucket.org/uonmoodle/moodle-fileconverter_onedrive/issues/1/max-file-size-supported-is-4mb-should#comment-50552953 for a full picture

mattporritt commented 5 years ago

@aspark21 I've merged your pull request to add: png, jpg, txt and gif. Before I close this issue, have you done any testing for those other files you've listed? I'm surprised that a few of them don't work (provided we declared that they did in the plugin code).

Also you can take the office archive from the repo and uncompress it locally (on linux), then run the libreOffice executable locally to test the conversion, the rough commands are: tar xvzf /var/www/moodle/files/converter/librelambda/libre/lo.tar.gz ./instdir/program/soffice --headless --invisible --nodefault --nofirststartwizard \ --nolockcheck --nologo --norestore --convert-to pdf --outdir $(pwd) a.txt Where a.txt is the source file you want to convert. I'll do some testing of the remaining formats myself, but let me know if you test any as well.

Cheers,

cybernotic commented 5 years ago

Hi Matt, I have been testing file types on our Moodle 3.7 test server. Successfully tested docx, pdf, png,jpg,txt,gif (inc animated) and combinations of those types, although currently these test are standard and just to see if the file types convert to PDF within moodle after clicking on the Grade button. I have run in to an issue with htlm. I used a simple html file with no special tags: `

Test File This is a test!

</html/> And another with links and image tags, both failed to convert, the simple html file showed a blank page after clicking on Grade and the other continued to hang, but the log file result showed successful. I was unable to run the libreOffice exe locally because of version issues: lib64/libc.so.6: versionGLIBC_2.14' not found, will sort this out and continue testing.

Regards David

aspark21 commented 5 years ago

Hi Matt,

Thanks for taking in my commit. David - @cybernotic - has being doing the testing for the one's currently declared by you & in my additions. The full list is occcurences of file types which unoconv supports but which haven't yet been declared in librelambda - i.e. pending testing shows they work.

The HTML one is an interesting case though because if someone saves a website with all the assets and submitted that to the Moodle assignment the assets would not be passed along to the converter so the page is doomed to be rendered horribly. I'm not sure of use cases but seems maybe more likely that an html document being graded would be in computer science in which case viewing the underlying code - i.e. as a text document - would make more sense than as a rendered web page. (?)

David - if you could take a quick look through submissions where html was submitted and figure out why, then maybe would guide us between both options.

Think the other file types would be nice to test but we're going to be tied up until August so may come back to these after our upgrade & go-live with this.

Thanks Alistair