catalyst / moodle-local_aws

A moodle plugin containing Amazon's SDK for PHP.
17 stars 30 forks source link

This may be obsolete from Moodle 4.4+ #69

Open marxjohnson opened 9 months ago

marxjohnson commented 9 months ago

As of MDL-78511, moodle core includes the AWS SDK to support the use of SNS for multi-factor authentication: https://github.com/moodle/moodle/commit/9b98f78d2a4bc2ef13143a17530e73ba22c1dae6

This may mean that this plugin is no longer required from 4.4 onwards. We should do some testing to confirm this.

marxjohnson commented 9 months ago

I have done some initial tests and got ObjectFS working on 4.4 without local_aws. The helper code in classes/ has been ported to moodle core, although in an odd place so I have raised a tracker issue to move it to a core namespace so it can be readily reused. With that in place, we'd be able to drop this as a dependency from our other AWS plugins from 4.4+.

marxjohnson commented 8 months ago

https://tracker.moodle.org/browse/MDL-80736 Has now been integrated, so from 4.4 the AWS SDK will be available in core, with the helper code copied from this plugin under the \core\aws namespace.