search

catalyst / moodle-local_datacleaner

Reduce, filter, and anonymize moodle data for non-prod environments
https://moodle.org/plugins/local_datacleaner
19 stars 17 forks source link

Unit tests: scheduled_tasks install.xml does not have correct permissions #103

Open kristian-94 opened 4 years ago

kristian-94 commented 4 years ago

This recent commit: https://github.com/catalyst/moodle-local_datacleaner/commit/155adac527f0ec17d2a6b368a564e3da1bb49d44

Modified file permissions when it shouldn't have. We need to change this back to 644 for the install.xml file and 755 for the db directory.

kristian-94 commented 4 years ago

@danmarsden I made a mistake with the last change, and left the file permissions as 777. This looks to be passing travis, when it's green can I merge it?

danmarsden commented 4 years ago

Whoops - I should have caught that too!! I've hit that a few times myself too!

kristian-94 commented 4 years ago

Yes, locally you have to change the permissions to let moodle do the save action, but have to remember to change it back after.