Closed jwalits closed 1 year ago
The keepusernames setting from the Scramble user data page is not being respected.
Culprit: https://github.com/catalyst/moodle-local_datacleaner/blob/master/cleaner/users/classes/clean.php#L64
The function get_user_criteria(); - https://github.com/catalyst/moodle-local_datacleaner/blob/master/classes/clean.php#L182 - expects the module config to be passed in, instead it is passing the list of cli options get_user_criteria(static::$options); thus never actually keeping the usernames as they are
get_user_criteria();
get_user_criteria(static::$options);
I'll work on a patch to fix it
The keepusernames setting from the Scramble user data page is not being respected.
Culprit: https://github.com/catalyst/moodle-local_datacleaner/blob/master/cleaner/users/classes/clean.php#L64
The function
get_user_criteria();- https://github.com/catalyst/moodle-local_datacleaner/blob/master/classes/clean.php#L182 - expects the module config to be passed in, instead it is passing the list of cli optionsget_user_criteria(static::$options);thus never actually keeping the usernames as they areI'll work on a patch to fix it