Name Trim issues - Githubissues

Heyo,

So ran into an issue with our system. We had a group name that had an escaped character in the name. on line 201 of helper.php you check if the system group name and the sync table are the same, and when they are not you trigger the update, but the update trims the name and triggers an error on the other side with name in use instead of just overwriting the name.

Starting group membershipsynchronisation... Updating group 横浜 : 未確定 (未確定) - in 929 with idnumber 40-8-99-X

Error from the script: Warning: Undefined property: stdClass::$id in /var/www/html/moodle41-20221213/group/lib.php on line 422 ... used 10882 dbqueries ... used 4.7551400661469 seconds Scheduled task failed: Sync enrolment groups (local_enrolgroup\task\sync_groups),IDナンバーがすでに使用されています。 Backtrace:

line 204 of /local/enrolgroup/classes/task/helper.php: call to groups_update_group()
line 112 of /local/enrolgroup/classes/task/helper.php: call to local_enrolgroup\task\helper->sync_groups_for_course()
line 59 of /local/enrolgroup/classes/task/sync_groups.php: call to local_enrolgroup\task\helper->sync_groups()
line 259 of /lib/cronlib.php: call to local_enrolgroup\task\sync_groups->execute()
line 167 of /admin/cli/scheduled_task.php: call to cron_run_inner_scheduled_task()

Code from helper.php that triggers the issue: // Check whether the group should be updated $localgroup = $localgroups[$idnumber]; if ($localgroup->name !== $name) { <----- the whitespace triggers this // Update it. $trace->output("Updating group {$name} in {$courseid} with idnumber {$idnumber}"); groups_update_group($data); }

Moodle code in group/lib.php where things happen:

function groups_update_group($data, $editform = false, $editoroptions = false) { global $CFG, $DB, $USER;

$context = context_course::instance($data->courseid);

$data->timemodified = time();
if (isset($data->name)) {
    $data->name = trim($data->name); <----------- This little devil screws it all up!
}
if (isset($data->idnumber)) {
    $data->idnumber = trim($data->idnumber);  <----------- I imagine this is also a similar bug point as well. 
    if (($existing = groups_get_group_by_idnumber($data->courseid, $data->idnumber)) && $existing->id != $data->id) {
        throw new moodle_exception('idnumbertaken');
    }
}

catalyst / moodle-local_enrolgroup

Name Trim issues #4