catalyst / moodle-local_smartmedia

Moodle LMS Smartmedia local plugin
Other
7 stars 5 forks source link

Improve error handling #168

Closed brendanheywood closed 4 years ago

brendanheywood commented 4 years ago

Many errors don't appear to be handled, or at least the error message needs a lot more context, eg

62eb9efa694a:1021 local_smartmedia: Processing media file metadata
Incorrect BOM value
Error reading comment frame, skipped
[h264 @ 0x558d3dbdc2c0] A non-intra slice in an IDR NAL unit.
[h264 @ 0x558d3dbdc2c0] decode_slice_header error

We'd want:

1) more context of the task, file, etc because these get interleaved in cron in among other log lines 2) what type of error we got, 3) should this bung file be flagged somehow in the db so its not retrying the same file over and over