search

catalyst / moodle-mod_facetoface

Facetoface Module for Moodle 2.0 and above
https://moodle.org/plugins/view/mod_facetoface
GNU General Public License v3.0
6 stars 51 forks source link

Limit candidate attendees to users enrolled in course #95

Closed alexmorrisnz closed 2 years ago

dmitriim commented 2 years ago

Hi @alexmorrisnz I don't know a background behind this change, but it looks like it changes an existing logic of building a list of users. Would you consider to add an extra setting to be able to change this logic optionally? That should be relatively easy change that may help people relying on the existing way to be happy.

alexmorrisnz commented 2 years ago

Hi @dmitriim I've added a admin level setting to control this.

This has come about as we have a client with 150K+ users who are running into issues with adding the wrong users to sessions as they share names with users not enrolled in the course.

Once this is merged I'll submit two more PRs to add it to 3.11 and 3.4+ branches

dmitriim commented 2 years ago

@alexmorrisnz can you please create an issue? That would help other people who potentially struggling with the same issue to see that it has been fixed already.

dmitriim commented 2 years ago

The change looks good to me, but I'd like @danmarsden to have a look also before we can merge it in.

dmitriim commented 2 years ago

@alexmorrisnz probably you also want to bump a version to make sure lang changes are applied.

danmarsden commented 2 years ago

+1 from me (after version bump is also added) - feel free to merge that when ready! :-)

dmitriim commented 2 years ago

@alexmorrisnz this one is merged. Please back-port to MOODLE_34_STABLE and MOODLE_311_STABLE. Thanks!