catalyst / moodle-mod_reengagement

Allows timed release of content and emails users to remind them to complete a course activity
23 stars 39 forks source link

Declare $perpagevisible, $perpagestring, $perpagesize #117

Closed aneno-m-e closed 2 years ago

aneno-m-e commented 2 years ago

Fix for issue #116

danmarsden commented 2 years ago

@aneno-m-e can we please try to use the same location/format for these as the MOODLE_400_STABLE branch? - that way if we cherry-pick other things it won't conflict as bad? - see: https://github.com/catalyst/moodle-mod_reengagement/blob/MOODLE_400_STABLE/view.php#L156-L160

aneno-m-e commented 2 years ago

Change done, I did a quick check with a git diff and those lines are good now.

danmarsden commented 2 years ago

great thanks!