Completion time at 01/01/1970

[GabGuev]

Hello, In the database the completiontime empty is at 0, the code considers it like a timestamp so when it formats it, it gives 1/01/1970

It this line that poses a problem: https://github.com/catalyst/moodle-mod_reengagement/blob/34355e5235688ca839ec907abf0d540994cf74a1/classes/table/reengagement_participants.php#L423

I propose this correction : return $data->completiontime ? userdate($data->completiontime, get_string('strftimedatetimeshort', 'langconfig')) : '-';

For have that instead:

Thanks 😃

[danmarsden]

thanks for the report, feel free to submit a pull request with that change otherwise it may sit here for a while.

[danmarsden]

thanks for the PR! - flagging this as closed.

[GabGuev]

Thanks @danmarsden! I'm glad to have contributed :)