catalyst / moodle-mod_reengagement

Allows timed release of content and emails users to remind them to complete a course activity
23 stars 39 forks source link

Latest Reengagement plugin version on Moodle 4.1 is not populating shortcodes in email with actual user data #130

Open adjosh opened 1 year ago

adjosh commented 1 year ago

Hello Dan,

For the third-party recipient, the shortcodes for %userfirstname% %userlastname% are not being replaced by the real user's First and Last Name when they receive the email. What could be the problem? Here is a screenshot of an email with the shortcode tags present.

Screen Shot 2023-03-18 at 6 03 10 PM

Thanks for any guidance. Best, Sarah Ashley Solutions Architect MoodleUS

danmarsden commented 1 year ago

Hey Sarah - nothing that comes to mind - could be a bug in the thirdparty content template translation - you'll need to get a developer to look into this further - feel free to send us a pull request if you track down a bug! - thanks.

adjosh commented 1 year ago

Hi Dan, Thanks for the pointer! So, we have the en_us language pack set to default. Is that where you mean? I will have someone check and get back to you. Thanks again.

danmarsden commented 1 year ago

not quite - it could be a bug in the code that triggers the notification - you'll need a developer to investigate further and see if they can spot the issue that is occurring (and hopefully send us a pull request)

adjosh commented 1 year ago

Got it, okay, thanks Dan. I will ask our Dev Team to take a look.

Best, Sarah