search

catalyst / moodle-mod_reengagement

Allows timed release of content and emails users to remind them to complete a course activity
23 stars 39 forks source link

Notify time is universal, not by course and activity #143

Open Urpokarhu1 opened 7 months ago

Urpokarhu1 commented 7 months ago

Hello,

I have noticed a bug, notify time is universal for whole system and activity. It should be per activity, not per system.

danmarsden commented 5 months ago

this could be related to #149 - but we really need a bit more info to be able to reproduce this ... It would be good if you could try to reproduce with the latest code now that #149 has landed.

Urpokarhu1 commented 4 months ago

Hello,

Is tested again with version mod_reengagement 2023020804 and problem persists.

  1. Create course1 and course2
  2. Create re-engagement on course1 with settings:

  1. Notice the date and time in "notify time"-column. for example 24/04/24, 10:15

  2. Create re-engagement on course2 with settings:

  1. Notice how "notify time" is identical to a course1 re-engagement-activity for example 24/04/24, 10:15 and not what it should be according to re-engagement-activity settings on this course.

course1 image

course2 image

Urpokarhu1 commented 4 months ago

You should also check https://github.com/catalyst/moodle-mod_reengagement/issues/151