catalyst / moodle-mod_reengagement

Allows timed release of content and emails users to remind them to complete a course activity
23 stars 39 forks source link

fix issue 140 - add reengagement_get_coursemodule_info() function #149

Closed iv-enovation closed 5 months ago

iv-enovation commented 5 months ago

fix for the issue 140 - saving a reengagement activity completes the activity for all users

the new function is added to lib.php that populates customdata, so in /completion/classes/activity_custom_completion.php in public function get_available_custom_rules() $customdata is not empty and get_overall_completion_state() does not default to returning COMPLETION_COMPLETE

danmarsden commented 5 months ago

looks sensible - thanks for tracking that down and submitting a PR - I've merged that in!