search

catalyst / moodle-mod_reengagement

Allows timed release of content and emails users to remind them to complete a course activity
24 stars 42 forks source link

mod/reengagement: convert emails to use messaging system #35

Closed euven closed 6 years ago

euven commented 6 years ago

Would be good if someone could give this another quick test ;)

danmarsden commented 6 years ago

looks like passing stdClass object to message_send is deprecated and planned for removal in 3.6? https://github.com/catalyst/moodle-mod_reengagement/pull/35/commits/a8b0b6fcf6c02841061f3f440c63a8619526d18c#diff-828043dc9f8d10ccd58ff8b96297794fR541

looks like more info in: https://tracker.moodle.org/browse/MDL-47162

danmarsden commented 6 years ago

I think it's supposed to be: $eventdata = new \core\message\message();

euven commented 6 years ago

i'll take a look at updating the calls

euven commented 6 years ago

There you go @dan ;)

Have another test and let me know if you find any other issues.

danmarsden commented 6 years ago

sweet - I've merged into master - will cherry-pick into other branches.

danmarsden commented 6 years ago

have cherry-picked back to Moodle 3.2 branch and have created a new Totara 10 branch with the same commits. I haven't backported to Moodle 3.1 branch or Totara 9 branch because the change to require core/message/message class isn't in the older releases. If you think we need to backport further we might need to copy your old code that used stdclass() instead?

euven commented 6 years ago

Nah I think it's good like that for now - thanks @danmarsden !