search

catalyst / moodle-mod_reengagement

Allows timed release of content and emails users to remind them to complete a course activity
23 stars 40 forks source link

Notify time adds 10 extra minutes. (Improve reporting on users going through re-engagement process.) #67

Open Urpokarhu1 opened 4 years ago

Urpokarhu1 commented 4 years ago

Hello,

"notify time"-column date/time should stop when reminder count is run out but it adds 10 minutes to that time for some reason.

Steps to repeat:

  1. Create engagement
  1. Notice how the last email message is received at f.ex

06.05.2020 13:21

but if you look inside the re-engagement activity "notify time" states 13:31 and not 13:21 as it should.

danmarsden commented 4 years ago

I can't see us spending any time on changing this behaviour but feel free to help by submitting a pull request.

I suspect the better solution would be to improve the reporting page rather than changing how the cron process works - the "emailtime" should not be used "on it's own" to indicate when the user wil next receive an e-mail - other items should be combined like reminder count etc.

thanks,

Urpokarhu1 commented 4 years ago

Hello,

I'm not a coder but to my understanding "notify time" states when was the last message was sent or when will the next message be sent + the time delay you have set.

It also seems that "notify time" is relative to the "after delay" -value.

So if you are using f.ex. 1 week/month/year then "notify time" will be really misleading when it will state that the last message is going to be sent after 1 week/month/year after the last actual message that has already been sent.

So for example:

I think easy way to fix this would be to add column "sent messages/out of all messages", it would be easy to understand.

danmarsden commented 4 years ago

as mentioned in the xml comments - notify time is the time when user should be emailed next. It is not "the time the user was last sent an email" - it is not designed to be interpreted in the way you are currently looking at it.

It sounds like what you are asking for is a "feature request" that alows you to see when the email was last sent. This is not something we are currently working on. Pull requests and or funding for further development is always welcome.

thanks,

Urpokarhu1 commented 4 years ago

Hello,

I have only read "normal" documentation, all of discussion available on re-engagement and done hours of testing myself.

If "notify time" tells you when the next message should be sent (even if message count have been reached) it will be really confusing in a case I explained earlier since as a teacher you are thinking next message will be sent when plugin states so. So if message count have been reached "notify time" should state "no futher messages" etc?

And I agree, the latter part of my message was feature requeish.

danmarsden commented 4 years ago

thanks - feel free to get in touch privately if you would like to fund further improvements to the plugin.