search

catalyst / moodle-mod_reengagement

Allows timed release of content and emails users to remind them to complete a course activity
23 stars 40 forks source link

Fix 'Group: No group' filter in reengagement view #70

Closed alexmorrisnz closed 4 years ago

alexmorrisnz commented 4 years ago

Tested on Moodle 3.9, made a test course, selected 'Group: No group' in the filter on the view page, given the error shown: Screenshot from 2020-07-03 13-56-25

This pull request adds a check for the groupid of -1, it also appears to keep the filter of users in no groups working.

danmarsden commented 4 years ago

feels like there should be an api to do this a bit cleaner... but it works as-is so merging in for now anyway.