catalyst / moodle-mod_reengagement

Allows timed release of content and emails users to remind them to complete a course activity

23 stars 40 forks source link

Deprecation warnings on M3.9 #71

Closed alexmorrisnz closed 4 years ago

alexmorrisnz commented 4 years ago

Moodle 3.9 deprecates user_get_participants_sql() and core_user_renderer->unified_filter(). The replacement is \core\table\participants_search::class.

@danmarsden thoughts on moving mod_reenagement onto this new class and putting out a MOODLE_38_STABLE release for the current codebase?

danmarsden commented 4 years ago

yeah - I prefer that method (branching) over trying to support multiple branches and increasing our technical debt

alexmorrisnz commented 4 years ago

72 will resolve this

danmarsden commented 4 years ago

merged. Also - note the branch name change from "master" to "main" as per our move away from using the "master" terminology.