search

catalyst / moodle-mod_reengagement

Allows timed release of content and emails users to remind them to complete a course activity
23 stars 40 forks source link

RE-73: Fix restrict access by groups not working #75

Closed cwarwicker closed 2 years ago

cwarwicker commented 4 years ago

The method used to check if a course module should be 'available' to a user was not taking into account the possible restrict access settings of specific user groups.

This has been changed to use the filter_user_list method which should resolve that issue.

cwarwicker commented 4 years ago

This commit should fix #73

cwarwicker commented 2 years ago

Hi @danmarsden

We have another client reporting a similiar issue. DId you ever get a chance to look at this MR? Would it be a feasible fix?

Thanks.,

Conn

danmarsden commented 2 years ago

yeah - this PR was not correct also see comments in #74 - those 2 functions do different things and unfortunately do not check the same things.

This needs a developer to take a closer look and provide a safer/more complete patch.

cwarwicker commented 2 years ago

Ok, I'll have another look at it.