search

catalyst / moodle-mod_scormremote

A Moodle activity for serving SCORM packages remotely to another LMS across domains
https://moodle.org/plugins/mod_scormremote
Other
9 stars 3 forks source link

api undefined error on stable branch #30

Open glepod opened 1 year ago

glepod commented 1 year ago

This is as a result of the refactoring to meet type-safe equality operators

glepod commented 1 year ago

There is no error on this branch. https://github.com/catalyst/moodle-mod_scormremote/tree/test

After refactoring to meet coding standards an api undefined error is produced. Rollback of these changes produces a unexpected data for param arguments, expected array (recieved "[object Undefined]")

Steps to reproduce: Create new moodle env with scormremote plugin at 2169c7 Config scormremote as per readme.md Create course with scormremote activity Create scormremote wrapper. Create course to scorm package activity with scormremote wrapper Check that content is displayed correctly. Apply changes to amd/src/layer2.js from 81c1aa

Expected: eslint is validated and scorm content is displayed correctly

Actual: api undefined error is produced