Open glepod opened 1 year ago
Mostly comments to myself: while reviewing this I really wanted the log level to be properly passed into layer2 so its got levels and not just a boolean. On top of this I also would like to see the log levels mapped to console.warn console.error console.info etc which makes them much nicer to read and consume. I've made this new issue with some of this:
https://github.com/catalyst/moodle-mod_scormremote/issues/38
I was getting caught up in testing this because the was a ton of js errors in the console log and it wasn't clear to me if they were existing issues, or part of this patch or what. The plugin still worked despite them all through so I think it came down to a bootstrap ordering issue where it is trying to use the scorm api earlier than it should be
Closes #14